Added aria role and keyboard navigation. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The role-attribute is important when we make "none-interactive" elements interactive, such as SPANs. This makes it easier for person using screen readers and such to use the site. (http://www.w3.org/TR/wai-aria/roles) By having a tabIndex and support "enter" we can easily navigate to the upload element, and enter it via the keyboard. This makes our site more usable.
|
This is very good. 👍 |
shepherdwind
added a commit
that referenced
this pull request
Sep 15, 2015
Added aria role and keyboard navigation.
|
1.4.4 published |
|
Nice! It does seem to be something wrong with the 1.4.4-release as no of the changes are reflected in that release (http://registry.npmjs.org/rc-upload/-/rc-upload-1.4.4.tgz). |
|
install 1.5.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role-attribute is important when we make "none-interactive"
elements interactive, such as SPANs. This makes it easier for
person using screen readers and such to use the site.
(http://www.w3.org/TR/wai-aria/roles)
By having a tabIndex and support "enter" we can easily navigate
to the upload element, and enter it via the keyboard. This makes
our site more usable.