Address missing daypicker width when calendarMonthPadding theme variable is undefined #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-patch: fixes/refactors/etc
majapw
force-pushed
the
maja-fix-daypicker-width-when-padding-is-NaN
branch
from
f391158 to
8493c23
Compare
|
@ljharb I added a test case. :) Notably, |
|
tbh I'm pleased with myself that I didn't know that off the top of my head |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352
We added a new theme variable (
horizontalMonthPadding) in v17.2.0. Unfortunately, when it was undefined, the effect was a trashfire (the daypicker width would be set toNaN). This PR addresses that edgecase and offers a fix!to: @ljharb @noratarano @codylawson