Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: watch and useWatch without parameters return type #11359

Merged
merged 5 commits into from
Jan 13, 2024
Merged

Fix: watch and useWatch without parameters return type #11359

merged 5 commits into from
Jan 13, 2024

Conversation

eladattias1996
Copy link
Contributor

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jan 3, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@bluebill1049
Copy link
Member

thanks @eladattias1996 very much for the contribution!

@bluebill1049 bluebill1049 merged commit fdbadbb into react-hook-form:master Jan 13, 2024
7 checks passed
@eladattias1996 eladattias1996 deleted the fix/watch-return-type branch January 15, 2024 06:45
@RulerOfCakes RulerOfCakes mentioned this pull request Feb 5, 2024
Merged
@Moshyfawn Moshyfawn mentioned this pull request Feb 5, 2024
Closed
1 task
bluebill1049 added a commit that referenced this pull request Feb 6, 2024
@bluebill1049
Revert "⌨️ fix #10734 watch and useWatch without parameters return ty…
7cffc95 
…pe (#11359)"

This reverts commit fdbadbb.
rafaelcalhau pushed a commit to rafaelcalhau/react-hook-form that referenced this pull request May 5, 2024
@eladattias1996 @bluebill1049 @rafaelcalhau
⌨️ fix react-hook-form#10734 watch and useWatch without parameters re…
6269046 
…turn type (react-hook-form#11359)

Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
rafaelcalhau pushed a commit to rafaelcalhau/react-hook-form that referenced this pull request May 5, 2024
@bluebill1049 @rafaelcalhau
Revert "⌨️ fix react-hook-form#10734 watch and useWatch without param…
facd4f9 
…eters return type (react-hook-form#11359)"

This reverts commit fdbadbb.
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Closed
@aaronch12Ch aaronch12Ch mentioned this pull request May 19, 2024
Open
@DeFiTON DeFiTON mentioned this pull request May 24, 2024
Open
@fer-rouco fer-rouco mentioned this pull request May 24, 2024
Open
@Niraj-Dilshan Niraj-Dilshan mentioned this pull request May 25, 2024
Open
@fer-rouco fer-rouco mentioned this pull request May 25, 2024
Open
@DeFiTON DeFiTON mentioned this pull request May 25, 2024
Open
@Niraj-Dilshan Niraj-Dilshan mentioned this pull request May 26, 2024
Open
@jul1oCesar0 jul1oCesar0 mentioned this pull request May 28, 2024
Closed
@peterleiva peterleiva mentioned this pull request May 29, 2024
Open
@CalPinSW CalPinSW mentioned this pull request Jun 1, 2024
Merged
@ashramwen ashramwen mentioned this pull request Jun 5, 2024
Open
@kalbroni7 kalbroni7 mentioned this pull request Jun 6, 2024
Open
@fer-rouco fer-rouco mentioned this pull request Jun 11, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 11, 2024
Closed
@talhasabri talhasabri mentioned this pull request Jul 12, 2024
Closed
@tural-xanaliyev tural-xanaliyev mentioned this pull request Jul 17, 2024
Open
@sanjayips sanjayips mentioned this pull request Jul 17, 2024
Open
@benhunter benhunter mentioned this pull request Jul 17, 2024
Open
@khangnguyen213 khangnguyen213 mentioned this pull request Jul 17, 2024
Open
@liurm97 liurm97 mentioned this pull request Jul 22, 2024
Open
@fer-rouco fer-rouco mentioned this pull request Jul 24, 2024
Open
@DeFiTON DeFiTON mentioned this pull request Jul 24, 2024
Open
@Niraj-Dilshan Niraj-Dilshan mentioned this pull request Jul 24, 2024
Open
@tural-xanaliyev tural-xanaliyev mentioned this pull request Jul 25, 2024
Open
@canarycr canarycr mentioned this pull request Jul 28, 2024
Open
@muthu-apppen muthu-apppen mentioned this pull request Jul 30, 2024
Open
@bakemonostan bakemonostan mentioned this pull request Aug 6, 2024
Open
@talhasabri talhasabri mentioned this pull request Aug 20, 2024
Closed
@zntb zntb mentioned this pull request Aug 21, 2024
Closed
This was referenced Aug 21, 2024
Open
Open
Open
Open
@DeFiTON DeFiTON mentioned this pull request Aug 24, 2024
Open
@tural-xanaliyev tural-xanaliyev mentioned this pull request Aug 24, 2024
Open
@Niraj-Dilshan Niraj-Dilshan mentioned this pull request Aug 25, 2024
Open
@talhasabri talhasabri mentioned this pull request Aug 25, 2024
Closed
@fer-rouco fer-rouco mentioned this pull request Aug 25, 2024
Open
@Niraj-Dilshan Niraj-Dilshan mentioned this pull request Aug 29, 2024
Open
@Teslax33 Teslax33 mentioned this pull request Sep 9, 2024
Open
@violetina violetina mentioned this pull request Sep 11, 2024
Open
@Erik-EFL Erik-EFL mentioned this pull request Sep 11, 2024
Open
@tural-xanaliyev tural-xanaliyev mentioned this pull request Sep 13, 2024
Open
@zntb zntb mentioned this pull request Sep 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluebill1049 bluebill1049 bluebill1049 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

issue: useWatch<T>() (parameterless) and watch type from the useFormContext have different types
2 participants
@eladattias1996 @bluebill1049