Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update valibot dependency #726

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabian-hiller
Copy link
Contributor

We have improved the Standard Schema spec. Unfortunately, this leads to a breaking change in Valibot's type signature. The implementation remains the same.

@aboqasem
Copy link

aboqasem commented Dec 25, 2024

is it just the type signature? because it's failing:

Screenshot 2024-12-25 at 09 50 52

Using versions:

@hookform/resolvers 3.9.1
└─┬ react-hook-form 7.54.2 peer
react-hook-form 7.54.2
valibot 1.0.0-beta.9

EDIT:

I copied the exact code from https://github.com/react-hook-form/resolvers/blob/e523dde4d9f2ee0f6168fab3696ed4aeb59fc69a/valibot/src/valibot.ts into a local file and it is working, weird 🤔

@fabian-hiller
Copy link
Contributor Author

fabian-hiller commented Dec 25, 2024

._run is an internal API and the Valibot resolver does not use internal APIs. So I expect a mismatch between the Valibot version used by the resolver and your own code.

As this PR has not been merged yet, I guess @hookform/resolvers v3.9.1 does not support Valibot v1 beta yet. That's why you get this runtime error.

@bluebill1049
Copy link
Member

@fabian-hiller could you help resolve the conflict? I forgot to merge it 🙏 Merry xmas 🎄

@fabian-hiller
Copy link
Contributor Author

Hey, merry xmas! The conflict is in the bun.lockb file and is most likely not related to Valibot and this PR. Not sure if I should "fix" this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants