useUnmountEffect - callback is not updated when it changes

[andbjer]

Prior Issues

No prior issues

What is the current behavior?

The callback passed to useUnmountEffect is not updated when it changes.

Steps to Reproduce

Consider this component. On unmount, onSave is never called even if you've changed the value. Reproduction available here

interface IProps {
  initialValue: string;
  onSave: (value: string) => void;
}
export const Input = ({ initialValue, onSave }: IProps) => {
  const [value, setValue] = useState(initialValue);

  const handleSave = useCallback(() => {
    if (value !== initialValue) {
      onSave(value);
    }
  }, [value, initialValue, onSave]);

  useUnmountEffect(() => {
    handleSave();
  });

  return <input value={value} onChange={(e) => setValue(e.target.value)} />;
};

What is the expected behavior?

The callback passed to useUnmountEffect should be updated whenever the callback changes.

Environment Details

• @react-hookz/web version: 13.2.1
• react version: 17.0.2
• react-dom version: 17.0.2
• typescript version: 4.6.3
• OS: macOS Monterey (12.3.1)
• Browser: Google Chrome Version 101.0.4951.64
• Did this work in previous versions? No

[xobotyi]

🎉 This issue has been resolved in version 14.2.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀