Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initializeWithValue default not respected, fix docs and tests #1003

Merged
merged 5 commits into from
Nov 5, 2022
Merged

Fix initializeWithValue default not respected, fix docs and tests #1003

merged 5 commits into from
Nov 5, 2022

Commits on Nov 4, 2022

  1. fix(useStorageValue): Fix not respecting initilizeWithValue defaults 

    The bug was caused by accidental references to a variable with the raw options provided by props
instead of the variable with the props-provided options and default options merged.

fix #1002
    @ArttuOll
    ArttuOll committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    fe72b5a View commit details
    Browse the repository at this point in the history

  2. fix(useStorageValue): Set initializeWithValue to false by default 

    This option was previously true by default, which is in conflict with this library's goal of
supporting SSR out of the box. Also the documentation and the tests seem to presume that
initializeWithValue is false by default. This is not a breaking change since due to a bug (#1002)
initializeWithValue was effectively false by default already.

re #1002
    @ArttuOll
    ArttuOll committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    3207d0d View commit details
    Browse the repository at this point in the history

  3. Revert "fix(useStorageValue): Set initializeWithValue to false by def… 

    …ault"

This reverts commit 3207d0d.
    @ArttuOll
    ArttuOll committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    527867f View commit details
    Browse the repository at this point in the history

  4. test(useStorageValue): Adapt SSR tests to initializeWithValue being t… 

    …rue by default
    @ArttuOll
    ArttuOll committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    92aa184 View commit details
    Browse the repository at this point in the history

  5. docs(useLocalStorageValue & useSessionStorageValue): Fix mixed info o… 

    …n initializeWithValue

Previously the docs would imply in the top part that initializeWithValue was false by default, which
is not the case.
    @ArttuOll
    ArttuOll committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    81711e2 View commit details
    Browse the repository at this point in the history