Deprecate useSafeState #1096
Merged
Deprecate useSafeState #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useSafeState is an anti-pattern (detailed more in the associated PR) which merely hides a React's warning. As of React 18, this warning is not even shown anymore, which makes this hook even more unnecessary. BREAKING CHANGE: useSafeState is removed
Codecov Report
@@ Coverage Diff @@
## master #1096 +/- ##
==========================================
- Coverage 98.52% 98.49% -0.03%
==========================================
Files 63 62 -1
Lines 1082 1064 -18
Branches 180 179 -1
==========================================
- Hits 1066 1048 -18
Misses 2 2
Partials 14 14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xobotyi
approved these changes
Feb 4, 2023
|
What do you think about also removing |
|
That one still have valid usecases, when dealing with external queues, high frequency events etc. |
|
Hello @xobotyi , it's been a while. Do you think it would be time to merge this? |
|
yup |
|
🎉 This PR is included in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
useSafeStateis offered as a solution to situations where asynchronous functions attempt to update a component's state when the component has already unmounted, resulting in the famousCan't perform a React state update on an unmounted componenterror.useSafeSateis likeuseState, but it does anisMountedcheck before allowing the state to be set. This, according to the React team, is an anti-pattern. A more fresh take on the topic, confirmed by Dan Abramov, can be found here. I won't go in to the details of whyisMountedchecks are an anti-pattern, because I don't want to repeat the resources linked above.Additionally, the
Can't perform a React state update on an unmounted componenterror has been removed in React 18, because it was considered to be misleading and caused people to invent workarounds, which the React team considered harmful (the example of a harmful workaround in the linked discussion is actually almost exactlyuseIsMounted).For the above reasons, I think
useSafeStatehas no job anymore. Lastly, it should also be considered, whether or notuseIsMountedshould be removed also.This issue was also discussed a while back in #959 .
What is the expected behavior?
useStateshould be used instead ofuseSafeState. Asynchronous functions should be cancelled if the component unmounts or they should be ignored, if cancellation is not an option. From the author of the discussion linked above:How does this PR fix the problem?
useSafeStatewithuseState.useSafeState.useSafeStatefrom the documentation and examples.Checklist