Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new hook useCookie #117

Merged
merged 5 commits into from
Jun 11, 2021
Merged

feat: new hook useCookie #117

merged 5 commits into from
Jun 11, 2021

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Jun 11, 2021 •
edited
Loading

What new hook does?

Manages a single cookie.

Checklist

  • Have you read contribution guideline?
  • Does the code have comments in hard-to-understand areas?
  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
  • Have the docs been updated?
  • Have the tests been added to cover new hook?
  • Have you run the tests locally to confirm they pass?

@xobotyi xobotyi added the 🎂 new hook New hook added label Jun 11, 2021
@codecov
Copy link

codecov bot commented Jun 11, 2021 •
edited
Loading

Codecov Report

Merging #117 (77b458b) into master (be6fff9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        30    +1     
  Lines          427       470   +43     
  Branches        80        84    +4     
=========================================
+ Hits           427       470   +43
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/useCookie/useCookie.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be6fff9...77b458b. Read the comment docs.

@xobotyi xobotyi requested a review from JoeDuncko June 11, 2021 14:40
JoeDuncko
JoeDuncko approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@JoeDuncko JoeDuncko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and even includes options on the remove, which was an issue with react-use, see streamich/react-use#1524 .

Thank you!

This was referenced Jun 11, 2021
Open
Open
@xobotyi xobotyi merged commit faae68b into master Jun 11, 2021
@xobotyi xobotyi deleted the useCookie branch June 11, 2021 16:44
github-actions bot pushed a commit that referenced this pull request Jun 11, 2021
@semantic-release-bot
chore(release): 1.27.0 [skip ci]
82032be 
# [1.27.0](v1.26.0...v1.27.0) (2021-06-11)

### Features

* new hook `useCookie` ([#117](#117)) ([faae68b](faae68b))
@xobotyi
Copy link
Contributor Author

xobotyi commented Jun 11, 2021

🎉 This PR is included in version 1.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeDuncko JoeDuncko JoeDuncko approved these changes

Assignees
No one assigned
Labels
🎂 new hook New hook added released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xobotyi @JoeDuncko