feat: add maxWait parameter to useDebouncedCallback hook
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 15 32 +17
Lines 111 543 +432
Branches 14 100 +86
==========================================
+ Hits 111 543 +432
Continue to review full report at Codecov.
|
7 tasks
|
While we are here, should we also implement |
|
Leading and trailing is only a matter of single implementation for both, throttle and debounce (if you look their throttle - it is only rewrapped debounce). |
JoeDuncko
approved these changes
Jun 16, 2021
xobotyi
force-pushed
the
improve-useDebouncedCallback
branch
from
8207e8a
to
ae8dc44
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2021
# [3.0.0](v2.2.0...v3.0.0) (2021-06-16) ### Bug Fixes * rename useThrottleCallback and useDebounceCallback ([#130](#130)) ([77f66d7](77f66d7)), closes [#129](#129) ### Features * add `maxWait` parameter to `useDebouncedCallback` hook ([#131](#131)) ([600baa8](600baa8)) * change args for `useThrottledCallback` and `useDebouncedCallback` ([#132](#132)) ([131d98e](131d98e)) * new hooks `useDebouncedEffect` and `useDebouncedState` ([#133](#133)) ([1d164ff](1d164ff)) ### BREAKING CHANGES * `delay` and `deps` arguments are swapped position for `useThrottledCallback` and `useDebouncedCallback` hooks to be aligned with `useCallback` signature. * `useDebounceCallback` renamed to `useDebouncedCallback` `useThrottleCallback` renamed to `useThrottledCallback`
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxWaitdefines maximum amount of milliseconds that function can be delayed before it's force execution. 0 means no max wait (default).should be merged after #130
Checklist