Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(451): attempt to fix issue #451 #539

Merged
merged 1 commit into from
Dec 23, 2021
Merged

fix(451): attempt to fix issue #451 #539

merged 1 commit into from
Dec 23, 2021

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Dec 23, 2021

How does this PR fix the problem?

Puts event handles registretion into layout effect instead of common effector

Checklist

  • Have you read contribution guideline?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
  • Have the docs been updated to match the changes in the PR?
  • Have the tests been updated to match the changes in the PR?
    Somewhy i cant manage tests to work for this case. State is updated but not for tests.
  • Have you run the tests locally to confirm they pass?

@xobotyi xobotyi self-assigned this Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #539 (342868e) into master (83cf3b0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #539   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines          776       778    +2     
  Branches       138       140    +2     
=========================================
+ Hits           776       778    +2
Impacted Files Coverage Δ
src/useStorageValue/useStorageValue.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83cf3b0...342868e. Read the comment docs.

@xobotyi xobotyi merged commit c2f99da into master Dec 23, 2021
@xobotyi xobotyi deleted the fix-451 branch December 23, 2021 11:44
github-actions bot pushed a commit that referenced this pull request Dec 23, 2021
@semantic-release-bot
chore(release): 12.0.3 [skip ci]
e319b51 
## [12.0.3](v12.0.2...v12.0.3) (2021-12-23)

### Bug Fixes

* **451:** attempt to fix issue [#451](#451) ([#539](#539)) ([c2f99da](c2f99da))
@xobotyi
Copy link
Contributor Author

xobotyi commented Dec 23, 2021

🎉 This PR is included in version 12.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xobotyi xobotyi

Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xobotyi