Add docs for the new API of useSessionStorageValue and useLocalStorageValue #970
Conversation
…e in documentation comment
|
Maybe you;ve been watching session storages that should not persist? because iframe is destructed after the reload and tehrefore session is over. |
|
Also i've been hoping you'll updatye my PR 🙃 |
|
Oh, I see. Well, I can push this to your PR-branch as well. |
|
All do it myself now, also tehre are some issues with description, that ill fix |
|
Oor you can do it, just realized that you've made it from fork. (as you are a member of a team you're now allowed to work straight on this repo) |
|
It appears I am unable to push the commits to your PR-branch, even though I am working directly in this repo. I am getting a 403 from GitHub. |
|
maybe it is somehow related to fact that im using ssh instead http.. dunno |
|
In fact, it seems that I'm not even able to push new branches to this repo. Maybe I don't have the required rights this organization? |
|
You right, there was an issue with permissions for team members. Now it should be ok |
What is the problem?
The API of
useStorageValuehas changed. The changes need to be reflected in the documentation ofuseSessionStorageValueanduseLocalStorageValue.What changes does this PR make to fix the problem?
Modify the relevant pieces of the docs. Please make sure that I did not miss anything.
Also, do the current examples seem a bit weird to you? They don't really persist the values the user types into the inputs and you cannot see anything come up in storages. But I guess that is because the example is in an iframe (but don't the iframe and the docs page come from the same domain? Then the iframe should be able to access the parent's storages).
Relates to #960