-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release @react-icons/all-files
#593
Comments
@maddhruv I believe it is caused by too many files generated, causing npm to refuse to host the package. Here is what happened when I was trying to publish the package under my own npm scope: |
I think by |
Hey @nolanleung looks like with the latest release as well, the |
I tried to publish, but it was rejected due to too many files. I think I need to plan on splitting the package. |
One possible solution is to split the ESM and CJS packages, which could reduce the number of files to half. |
I don't think that is a good solution. Currently the package contains 80,000 files, which is causing problems such as long installation times. Also, the number of icons will continue to increase. |
While it may defeat the purpose of having a package named "all-files", maybe the icons could be split up into packages based on their icon library? So, a |
Those packages already exist but they don't contain the separate icons. The main setup should just be fixed to export single files in each package and then you should deprecate this duplicate "all-icons" package. |
To all the people still finding a workaround, we can also do: npm install link_to_gzipped_tarball. For an Example: $ npm i https://github.com/react-icons/react-icons/releases/download/v4.7.1/react-icons-all-files-4.7.1.tgz This also adds a dependency in the package.json file. References:
|
…ore and /react packages -Added source maps to the outputs -Remove unnecessary dependencies -Removed unused assets folder from /react -Fixed issue with the 'react-icons' package react-icons/react-icons#593
When is this being updated? |
This had to be updated using the GitHub download becuase of react-icons/react-icons#593
…ore and /react packages -Added source maps to the outputs -Remove unnecessary dependencies -Removed unused assets folder from /react -Fixed issue with the 'react-icons' package react-icons/react-icons#593
Describe the bug
Looks like
@react-icons/all-files
hasn't been released lately withreact-icons
so I am missing the newly added icons packsMinimal sample repository
Not Required
Expected behavior
For example Tabler Icons are missing from
all-files
, Can you please do a release with latestreact-icons
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: