Skip to content

Commit

Permalink
improve comment
Browse files Browse the repository at this point in the history
  • Loading branch information
thymikee committed Oct 25, 2019
1 parent d7e0fa0 commit 4ab5666
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/platform-android/native_modules.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ class ReactNativeModules {
def reactNativeConfigOutput = ""

try {
// When running Gradle from CWD that's outside of JS project, it's necessary to pass a CWD that's close to JS app,// so that npx can resolve to correct local CLI, instead of possibly installed global, corrupting config output
// Running npx from the directory of the JS app which holds this script in its node_modules.
// We do so, because Gradle may be ran from a different directory, that's outside of JS project,
// in which case npx wouldn't resolve correct `react-native` binary
def cmdProcess = Runtime.getRuntime().exec(command, null, new File(this.jsAppDir))
def bufferedReader = new BufferedReader(new InputStreamReader(cmdProcess.getInputStream()))
def buff = ""
Expand Down

0 comments on commit 4ab5666

Please sign in to comment.