fix: add missing argument to xcodebuild shell (destination) (#1934)

- destination is used for to specify the arch for iOS build - this is needed for modules which require arch x84_64
react-native-community · May 16, 2023 · 76ce898 · 76ce898
1 parent a73cecc
commit 76ce898
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/packages/cli-platform-ios/README.md b/packages/cli-platform-ios/README.md
@@ -65,6 +65,10 @@ Explicitly set Xcode scheme to use.
 
 Explicitly set device to use by name. The value is not required if you have a single device connected.
 
+#### `--destination <string>`
+
+Explicitly extend distination e.g. "arch=x86_64"
+
 #### `--udid <string>`
 
 Explicitly set device to use by udid.

diff --git a/packages/cli-platform-ios/src/commands/buildIOS/buildProject.ts b/packages/cli-platform-ios/src/commands/buildIOS/buildProject.ts
@@ -20,6 +20,7 @@ export type BuildFlags = {
   port: number;
   terminal: string | undefined;
   interactive?: boolean;
+  destination?: string;
   extraParams?: string[];
 };
 
@@ -40,11 +41,12 @@ export function buildProject(
       '-scheme',
       scheme,
       '-destination',
-      udid
+      (udid
         ? `id=${udid}`
         : args.mode === 'Debug'
         ? 'generic/platform=iOS Simulator'
-        : 'generic/platform=iOS',
+        : 'generic/platform=iOS') +
+        (args.destination ? ',' + args.destination : ''),
     ];
 
     if (args.extraParams) {

diff --git a/packages/cli-platform-ios/src/commands/buildIOS/index.ts b/packages/cli-platform-ios/src/commands/buildIOS/index.ts
@@ -228,6 +228,10 @@ export const iosBuildOptions = [
     description:
       'Explicitly set device to use by name.  The value is not required if you have a single device connected.',
   },
+  {
+    name: '--destination <string>',
+    description: 'Explicitly extend distination e.g. "arch=x86_64"',
+  },
   {
     name: '--udid <string>',
     description: 'Explicitly set device to use by udid',