Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't copy font files into "assets" android folder in "react-native link" #111

Closed
punksta opened this issue Jan 23, 2019 · 3 comments
Closed

Comments

@punksta
Copy link

punksta commented Jan 23, 2019

react-native link is copping all fonts into assets folder for android.
For ios it is registering font files in ios project file without making files copies.

problem

I don't want to store copies of all fonts in android assets folder.

Suggestion

There are few ways of solving this:

  1. We can make gradle task in https://github.com/facebook/react-native/blob/master/react.gradle which will copy font files in "generated/assets" in build time. So fonts will be synced automatically same as images.
    I don't know is something similar possible for ios (registering fonts files in build time, without changing source code files)
  2. to make behavior similar to ios link command could just create text file file with font paths to track them instead of making copies. We can add this file to git. And then gradle task adds only fonts from this file, not all of them.

originally posted here react-native-community/discussions-and-proposals#89

@thymikee
Copy link
Member

thymikee commented Jan 23, 2019

We have quite a bunch of issues regarding improvements in link command, can you check if any of those relate to your request? Would be nice to consolidate some stuff if possible, but I think this one makes sense on its own.

You can find the issues labelled as command:link.

cc @ferrannp @grabbou

@punksta
Copy link
Author

punksta commented Jan 23, 2019

#74 - this is related, but not the same.

@grabbou
Copy link
Member

grabbou commented Mar 11, 2019

I am sorry @punksta to let you know, but this is unfortunately not a CLI issue. I will comment on the original issue with the details.

Thanks for filling this in - I didn't now that another way of doing that was possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants