feat: allow selection of iOS sim with --udid
#1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Mar 24, 2020
packages/platform-ios/src/commands/runIOS/__tests__/parseIOSDevicesList.test.ts
Show resolved
Hide resolved
| @@ -8,36 +8,24 @@ | |||
| import {Device} from '../../types'; | |||
|
|
|||
| /** | |||
| * Parses the output of `xcrun simctl list devices` command | |||
| * Parses the output of `xcrun instruments -s` command | |||
packages/platform-ios/src/commands/runIOS/parseIOSDevicesList.ts
Outdated
Show resolved
Hide resolved
|
Alright, added Catalyst support back and made it a bit more clear that that’s a supported target. |
|
@grabbou mind having a look? |
thymikee
reviewed
Mar 28, 2020
| }); | ||
| text.split('\n').forEach(line => { | ||
| const device = line.match( | ||
| /(.*?) (\(([0-9\.]+)\) )?\[([0-9A-F-]+)\]( \(Simulator\))?/i, |
There was a problem hiding this comment.
Added lowercase flag, because some UUIDs may be lower-cased (discovered while local testing). Included test
There was a problem hiding this comment.
Oh, good catch; thanks! Was it an iPhone?
thymikee
changed the title
--udid--udid
|
just update the cli-platform-ios inside @react-native-community/ hope it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This makes it possible to be very specific about what simulator to use in the same way you’d interact with tooling such as
simctl.Fixes #1078
Test Plan:
Given a device list like:
Simulator
Default
By UDID
Device
Default without iOS device connected
Default with iOS device connected
By UDID
Catalyst
By name
By UDID