Fix: allow Hermes Debugger to connect from Flipper #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reflects D20526486 by @rickhanlonii at Facebook: when Running Hermes Debugger from inside Flipper, the origin is localhost, but not the metro port. This fixes facebook/flipper#660 (comment)
mweststrate
requested review from
Esemesek,
grabbou and
thymikee
as code owners
thymikee
reviewed
Mar 31, 2020
packages/cli/src/commands/server/middleware/getSecurityHeadersMiddleware.ts
Show resolved
Hide resolved
|
A round of |
|
My github edit + circle ci workflow is the coolest and least efficient one possible :P. (and I actually have local checkout, so not sure why I am doing this, my one-last-error strategy is clearly not paying off😬) |
|
@mweststrate does this mean that the Hermes debugger is available in OSS now? @thymikee is it possible to get this into the 0.62.1 patch Friday? |
|
@rickhanlonii yes :) |
|
@rickhanlonii almost, I'll make a release in a moment. There's no need to patch React Native, since any CLI v4.x is covered by semver range |
|
I assume since it is in the semver range, people with existing projects
won't get the update then, due to lock files, affecting only new projects
as a result?
…On Wed, Apr 1, 2020 at 5:54 PM Michał Pierzchała ***@***.***> wrote:
@rickhanlonii <https://github.com/rickhanlonii> almost, I'll make a
release in a moment. There's no need to patch React Native, since this will
be in semver range
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1086 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN4NBHRLZ6FNLPABVILM2TRKNWUDANCNFSM4LXNOARA>
.
|
|
@mweststrate you're right. Invalidating CLI entries in lock file is necessary. |
|
Released in v4.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change reflects D20526486 by @rickhanlonii at Facebook: when Running Hermes Debugger from inside Flipper, the origin is localhost, but not the metro port. This fixes facebook/flipper#660 (comment)
Test Plan: