feat: add a programmatic dev server API #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Apr 17, 2020
thymikee
reviewed
Apr 17, 2020
|
At @thymikee's suggestion, I've split this PR up so it only includes the new |
thymikee
reviewed
Apr 24, 2020
thymikee
approved these changes
Apr 24, 2020
|
Published as a part of v4.8.0 |
This was referenced Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I work on Expo CLI, which uses React Native CLI to start the development server. Previously, we've done this by starting RN CLI as a subprocess. This has had some challenges, including slower boot-up time because we need to start another Node process, possibility to end up with a killed or zombie processes if there's an unhandled error, and having to parse all logs from JSON in stdout.
This PR refactors the
react-native startcommand and introduces a new package@react-native-community/dev-server-api, which includes a programmatic interface for starting the dev server middleware and WebSocket servers used by React Native. This allows tools like Expo CLI to interface with Metro directly and then attach the additional features provided by React Native CLI to the Metro HTTP server. (expo/expo-cli#1845 will make use of this package).Test Plan:
I have followed the Testing your changes instructions in
CONTRIBUTING.mdand started the dev server withnpx react-native start --watchFolders /Users/ville/Projects/react-native-cli/ --resetCache. After starting the server, I've verified the following features work:r