Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move launchDebugger etc. to cli-tools #1133

Merged
merged 1 commit into from
Apr 25, 2020
Merged

refactor: move launchDebugger etc. to cli-tools #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 0 additions & 66 deletions packages/cli/src/commands/server/launchDebugger.ts
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions packages/cli/src/commands/server/launchDefaultBrowser.ts
View file
Open in desktop

This file was deleted.

248 changes: 0 additions & 248 deletions packages/cli/src/commands/server/launchEditor.ts
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions packages/cli/src/commands/server/middleware/getDevToolsMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/
import http from 'http';
import {logger} from '@react-native-community/cli-tools';
import {launchDebugger, logger} from '@react-native-community/cli-tools';
import {exec} from 'child_process';
import launchDebugger from '../launchDebugger';

function launchDefaultDebugger(
host: string | undefined,
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/server/middleware/openStackFrameInEditorMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* LICENSE file in the root directory of this source tree.
*/
import http from 'http';
import launchEditor from '../launchEditor';
import {launchEditor} from '@react-native-community/cli-tools';

export default function getOpenStackFrameInEditorMiddleware({
watchFolders,
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/src/commands/server/middleware/openURLMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
* LICENSE file in the root directory of this source tree.
*/
import http from 'http';
import launchDefaultBrowser from '../launchDefaultBrowser';
import {logger} from '@react-native-community/cli-tools';
import {launchDefaultBrowser, logger} from '@react-native-community/cli-tools';

/**
* Handle request from JS to open an arbitrary URL in Chrome
Expand Down