Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes calls to process.cwd() in favor of using context.root #116

Merged
merged 3 commits into from
Jan 23, 2019

Conversation

kpsroka
Copy link
Contributor

@kpsroka kpsroka commented Jan 23, 2019

This probably removes all the ones that can be removed, and closes #75.

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo!

@thymikee
Copy link
Member

There are still couple of places that use process.cwd, would you mind checking that? Can be done as a separate PR as well.

@kpsroka kpsroka changed the title Removes calls to process.pwd() in favor of using context.root Removes calls to process.cwd() in favor of using context.root Jan 23, 2019
@kpsroka
Copy link
Contributor Author

kpsroka commented Jan 23, 2019

@thymikee I think that all of the remaining ones need to stay. They are either outside of the packages, or only used to print suggested command line calls.

@grabbou grabbou merged commit 1c18109 into react-native-community:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify "process.cwd()" calls
3 participants