Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema option on run-ios not installing and loading the right bundle #128

Merged

Conversation

misoguy
Copy link
Contributor

@misoguy misoguy commented Jan 25, 2019

Summary:

This PR adds schema folder to the ios build path
to resolve issue facebook/react-native#20497

Test Plan:

  1. Setup a different scheme with different environment variables for the same app. ex) exampleApp, exampleAppDev
  2. run react-native run-ios --scheme exampleApp
  3. should install and run exampleApp with a variable
  4. run react-native run-ios --scheme exampleAppDev
  5. should install and run exampleAppDev with b variable

@misoguy
Copy link
Contributor Author

misoguy commented Jan 25, 2019

@thymikee I could have a default value for the scheme but I think the scheme is always present with a default as this line is using it as a backup for appName. Let me know your thoughts :)

@thymikee
Copy link
Member

Oh, it wasn't clear by looking at the diff. Then it looks like it's all good, anybody would like to test that? :)

@thymikee thymikee requested review from grabbou and Esemesek January 25, 2019 17:37
@grabbou
Copy link
Member

grabbou commented Jan 31, 2019

Looks good. Tested locally. Shipping. Thank you <3

@grabbou grabbou merged commit b33d079 into react-native-community:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants