-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: run-android not finding scripts to overwrite #141
Conversation
I added support for running from React Native source. Note: |
['android'].concat(process.argv.slice(1)), | ||
{ stdio: 'inherit' } | ||
); | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CRNA is deprecated, so removing support for it anyway
This is critical bug that has to be shipped with next RC. |
*/ | ||
const possibleScriptLocation = path.resolve( | ||
__dirname, | ||
`../../../../../scripts/${scriptFile}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or you could add a new flag pathToReactNative
which you could pass to RNTester scripts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think this is a good idea and would solve few other issues we had already in start
command. Let me rewrite it by adding global --pathToReactNative
flag (similar to root) so that users can pass it and we can decide where to use it.
This is amazing for debugging too!
* Set up the `.packager.(env|bat)` file to ensure the packager starts on the right port. | ||
*/ | ||
const launchPackagerScript = require.resolve( | ||
`react-native/scripts/${scriptFile}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a reminder to convert this path to a flag passed to run-android
/run-ios
command
Fixes #126
We need to change this approach, issue tracking in #140.