fix: run-android not finding scripts to overwrite #141
Conversation
|
I added support for running from React Native source. Note: |
| ['android'].concat(process.argv.slice(1)), | ||
| { stdio: 'inherit' } | ||
| ); | ||
| } else { |
There was a problem hiding this comment.
CRNA is deprecated, so removing support for it anyway
|
This is critical bug that has to be shipped with next RC. |
| */ | ||
| const possibleScriptLocation = path.resolve( | ||
| __dirname, | ||
| `../../../../../scripts/${scriptFile}` |
There was a problem hiding this comment.
or you could add a new flag pathToReactNative which you could pass to RNTester scripts?
There was a problem hiding this comment.
Yeah, I think this is a good idea and would solve few other issues we had already in start command. Let me rewrite it by adding global --pathToReactNative flag (similar to root) so that users can pass it and we can decide where to use it.
This is amazing for debugging too!
| * Set up the `.packager.(env|bat)` file to ensure the packager starts on the right port. | ||
| */ | ||
| const launchPackagerScript = require.resolve( | ||
| `react-native/scripts/${scriptFile}` |
There was a problem hiding this comment.
a reminder to convert this path to a flag passed to run-android/run-ios command
Fixes #126
We need to change this approach, issue tracking in #140.