Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Change require to imports (alt) #150

Merged
merged 6 commits into from
Feb 5, 2019
Merged

[WIP] Change require to imports (alt) #150

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
538f651
refactor(imports): replaces most uses of require by import
Feb 3, 2019
ed12844
fix: fixes export and revert wrong change
Feb 4, 2019
18e5dbe
fix: fix import order
Feb 4, 2019
18e42e8
fix: revert export change
Feb 4, 2019
595c426
fix: revert global-cli/index
Feb 4, 2019
20e1825
fix: typo
Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/bundle/assetPathUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function getBasePath(asset: PackagerAsset) {
return basePath;
}

module.exports = {
export default {
getAndroidAssetSuffix,
getAndroidResourceFolderName,
getAndroidResourceIdentifier,
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ if (require.main === module) {
cli.run();
}

module.exports = cli;
sidferreira marked this conversation as resolved.
Show resolved Hide resolved
export default cli;
14 changes: 7 additions & 7 deletions packages/global-cli/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@
// /!\ DO NOT MODIFY THIS FILE /!\
// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

import fs from 'fs';
import path from 'path';
import exec from 'child_process'.exec;
import execSync from 'child_process'.execSync;
import chalk from 'chalk';
import prompt from 'prompt';
import semver from 'semver';
const fs = require('fs');
const path = require('path');
const exec = require('child_process').exec;
const execSync = require('child_process').execSync;
const chalk = require('chalk');
const prompt = require('prompt');
const semver = require('semver');
/**
* Used arguments:
* -v --version - to print current version of react-native-cli and react-native dependency
Expand Down