Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: disable logger in tests #155

Merged
merged 3 commits into from
Feb 6, 2019
Merged

refactor: disable logger in tests #155

merged 3 commits into from
Feb 6, 2019

Conversation

Esemesek
Copy link
Member

@Esemesek Esemesek commented Feb 6, 2019

Summary:

Disable annoying logs in a test environment.

Test Plan:

➜  react-native-cli git:(master) ✗ yarn test
yarn run v1.13.0
$ jest
 PASS  packages/cli/src/runIOS/__tests__/findMatchingSimulator-test.js
 PASS  packages/cli/src/util/__tests__/findSymlinkedModules-test.js
 PASS  packages/cli/src/server/util/debugger-ui/__tests__/DeltaPatcher-test.js
 PASS  packages/cli/src/core/__tests__/findPlugins-test.js
 PASS  packages/cli/src/link/__tests__/android/makeSettingsPatch-test.js
 PASS  packages/cli/src/link/__tests__/ios/getHeaderSearchPath-test.js
 PASS  packages/cli/src/core/__tests__/ios/findProject-test.js
 PASS  packages/cli/src/core/__tests__/android/getProjectConfig-test.js
 PASS  packages/cli/src/bundle/__tests__/getAssetDestPathAndroid-test.js
 PASS  packages/cli/src/runAndroid/__tests__/runOnAllDevices.test.js
 PASS  packages/cli/src/link/__tests__/pods/removePodEntry-test.js
 PASS  packages/cli/src/link/__tests__/ios/writePlist-test.js
 PASS  packages/cli/src/link/__tests__/ios/createGroup-test.js
 PASS  packages/cli/src/link/__tests__/pods/findLineToAddPod-test.js
 PASS  packages/cli/src/link/__tests__/android/makeBuildPatch-test.js
 PASS  packages/cli/src/core/__tests__/android/getDependencyConfig-test.js
 PASS  packages/cli/src/link/__tests__/ios/addSharedLibraries-test.js
 PASS  packages/cli/src/core/__tests__/android/findPackageClassName-test.js
 PASS  packages/cli/src/link/__tests__/link-test.js
 PASS  packages/cli/src/link/__tests__/pods/isInstalled-test.js
 PASS  packages/cli/src/core/__tests__/ios/findPodspecName-test.js
 PASS  packages/cli/src/link/__tests__/pods/findMarkedLinesInPodfile-test.js
 PASS  packages/cli/src/link/__tests__/ios/getGroup-test.js
 PASS  packages/cli/src/runIOS/__tests__/findXcodeProject-test.js
 PASS  packages/cli/src/core/__tests__/ios/getProjectConfig-test.js
 PASS  packages/cli/src/runIOS/__tests__/parseIOSDevicesList-test.js
 PASS  packages/cli/src/link/__tests__/ios/removeProjectFromProject-test.js
 PASS  packages/cli/src/link/__tests__/promiseWaterfall-test.js
 PASS  packages/cli/src/link/__tests__/ios/removeSharedLibrary-test.js
 PASS  packages/cli/src/bundle/__tests__/filterPlatformAssetScales-test.js
 PASS  packages/cli/src/link/__tests__/ios/isInstalled-test.js
 PASS  packages/cli/src/link/__tests__/ios/mapHeaderSearchPaths-test.js
 PASS  packages/cli/src/link/__tests__/ios/getHeadersInFolder-test.js
 PASS  packages/cli/src/link/__tests__/ios/removeProjectFromLibraries-test.js
 PASS  packages/cli/src/core/__tests__/android/readManifest-test.js
 PASS  packages/cli/src/link/__tests__/getProjectDependencies-test.js
 PASS  packages/cli/src/link/__tests__/pods/findPodTargetLine-test.js
 PASS  packages/cli/src/core/__tests__/findAssets-test.js
 PASS  packages/cli/src/link/__tests__/android/isInstalled-test.js
 PASS  packages/cli/src/link/__tests__/getDependencyConfig-test.js
 PASS  packages/cli/src/core/__tests__/android/findAndroidAppFolder-test.js
 PASS  packages/cli/src/link/__tests__/android/makePackagePatch-test.js
 PASS  packages/cli/src/bundle/__tests__/getAssetDestPathIOS-test.js
 PASS  packages/cli/src/core/__tests__/makeCommand-test.js
 PASS  packages/cli/src/link/__tests__/ios/hasLibraryImported-test.js
 PASS  packages/cli/src/link/__tests__/ios/addProjectToLibraries-test.js
 PASS  packages/cli/src/link/__tests__/ios/addFileToProject-test.js
 PASS  packages/cli/src/core/__tests__/android/findManifest-test.js
 PASS  packages/cli/src/core/__tests__/ios/findPodfilePath-test.js
 PASS  packages/cli/src/link/__tests__/ios/getTargets-test.js
 PASS  packages/cli/src/link/__tests__/ios/getBuildProperty-test.js
 PASS  packages/cli/src/link/__tests__/android/makeStringsPatch-test.js
 PASS  packages/cli/src/link/__tests__/android/makeImportPatch-test.js
 PASS  packages/cli/src/link/__tests__/ios/getPlist-test.js
 PASS  packages/cli/src/link/__tests__/ios/getPlistPath-test.js
 PASS  packages/cli/src/link/__tests__/groupFilesByType-test.js
 PASS  packages/cli/src/link/__tests__/android/applyPatch-test.js
 PASS  packages/cli/src/link/__tests__/android/normalizeProjectName-test.js

Test Suites: 58 passed, 58 total
Tests:       1 todo, 199 passed, 200 total
Snapshots:   4 passed, 4 total
Time:        8.226s
Ran all test suites.
✨  Done in 9.69s.

packages/cli/testSetup.js Outdated Show resolved Hide resolved
@grabbou
Copy link
Member

grabbou commented Feb 6, 2019

Looks good to me. @Esemesek, do you mind applying a suggestion by @thymikee?

@grabbou grabbou merged commit 5fa631d into master Feb 6, 2019
@thymikee thymikee deleted the Esemesek/test-logs branch February 16, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants