Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add "clean" command #1582

Merged
merged 10 commits into from
Apr 7, 2022
Merged

feat: add "clean" command #1582

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ae6511a
feat: add "clean" command
tido64 Apr 1, 2022
a9dbb09
prompt when --include is omitted
tido64 Apr 1, 2022
eeb9834
uncheck npm and yarn by default
tido64 Apr 6, 2022
5da6a19
replace execute with execa
tido64 Apr 6, 2022
b6a7555
add some tests
tido64 Apr 6, 2022
d25846b
don't show cocoapods on Windows
tido64 Apr 7, 2022
30f92c2
show hints for each group
tido64 Apr 7, 2022
043d78f
don't stop when encountering an unknown group
tido64 Apr 7, 2022
da94494
dim the group description
tido64 Apr 7, 2022
37bd255
add chalk to dependencies
tido64 Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/cli-clean/src/clean.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {getLoader} from '@react-native-community/cli-tools';
import type {Config as CLIConfig} from '@react-native-community/cli-types';
import chalk from 'chalk';
Copy link
Member

@thymikee thymikee Apr 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to add chalk to package.json. Hope this fixes the CI that started to fail with weird unrelated error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops 😄

import execa from 'execa';
import {existsSync as fileExists, rmdir} from 'fs';
import os from 'os';
Expand Down Expand Up @@ -57,7 +58,7 @@ async function promptForCaches(
name: 'caches',
message: 'Select all caches to clean',
choices: Object.entries(groups).map(([cmd, group]) => ({
title: `${cmd} (${group.description})`,
title: `${cmd} ${chalk.dim(`(${group.description})`)}`,
value: cmd,
selected: DEFAULT_GROUPS.includes(cmd),
})),
Expand Down