fix: improve cli interface #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Feb 13, 2019
packages/cli/src/cliEntry.js
Outdated
| } | ||
|
|
||
| if (!commander.args.length) { | ||
| commander.help(); | ||
| if (typeof command === 'string') { |
There was a problem hiding this comment.
this could be else clause to be more explicit :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes few of the issues that I've encountered working in a React Native repository.
When you pass a wrong command or provide no command at all (say, you want to print
--help) and your CLI works by setting--projectRootor--reactNativePath(in React Native repository, this is a must), you end up with a "Unrecognised option" error.This PR changes that, so that it works and is accepted.
It also fixes a missing path to a inited application that is a regression introduced in 72c3dd4#diff-d9b7abe65a1a1a0e0b19ec93292008eaR16. We wrongly assumed
process.cwd()remains the directory the command has been run from. Turns out, it's modified by the init script.