fix: correctly list ios devices and simulators

[roryf]

Summary:

Backports #1823 to 10.x branch.

After updating to RN 0.71.3 I was experiencing issue similar to #1807 (it would try to use my laptop as target device), hoping this can be merged to a 10.x release and fixed in a new RN 0.71.x version.

Fixes #1845

Test Plan:

• Ran node ../cli/packages/cli/build/bin.js run-ios verified it launched app in expected iPhone 14 simulator, where before it would error with out of box react native 0.71.1 failed run-ios facebook/react-native#35917 (comment)
• Ran node ../cli/packages/cli/build/bin.js run-ios --list-devices verified it listed all available simulators, and not my laptop as previous

> node ../cli/packages/cli/build/bin.js run-ios --list-devices            
warn Multiple Podfiles were found: ios/Podfile,vendor/bundle/ruby/2.7.0/gems/cocoapods-core-1.11.3/lib/cocoapods-core/Podfile. Choosing ios/Podfile automatically. If you would like to select a different one, you can configure it via "project.ios.sourceDir". You can learn more about it here: https://github.com/react-native-community/cli/blob/master/docs/configuration.md
info Found Xcode workspace "Foo.xcworkspace"
? Select the device you want to use › - Use arrow-keys. Return to submit.
❯   iPhone 12 mini 
    iPhone 8 Plus 
    iPad (10th generation) 
    iPhone 11 
    iPhone 13 
    iPhone SE (3rd generation) 
    iPod touch (7th generation) 
    iPhone 14 
    iPhone 14 Pro 
  ↓ iPhone 12 Pro

[adamTrz]

Thanks for the PR @roryf 🎉

Could you please resolve failing test? And then we can merge :)

[roryf]

@adamTrz should be resolved now

[roryf]

@adamTrz @thymikee thanks for merging, can a new 10.x release be cut?

[thymikee]

hey @roryf, I've released these packages:

 - @react-native-community/cli-doctor@10.2.1
 - @react-native-community/cli-platform-ios@10.2.1
 - @react-native-community/cli@10.2.1

They won't be automatically pulled by the RN 0.71, so we'd need to send a request to update the CLI

EDIT: sent: reactwg/react-native-releases#59

[lucasbento]

@thymikee @szymonrybczak @roryf could we potentially make this the default behaviour in case it fails to run run-ios on the first picked device? Basically prompt the user for selecting the device if it failed the first time.

Asking as the command seems to be defaulting to my Apple Watch (something to look into as well, I would be happy to do it) and might default to my physical device which will potentially fail as well as it's sometimes not in the same network.

[thrandale]

I am also seeing where it is picking my apple watch instead of my phone. And failing because of it