Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log-ios command #1890

Merged

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

Closes #1675

This PR connects output of two commandsxcrun simctl list --json devices and xcrun xcdevice list. One command outputs state, but doesn't return available. But second command xcrun xcdevice list outputs available but doesn't output state. So I connected outputs from both commands.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js log-ios

@github-actions github-actions bot added the docs Documentation change label Mar 28, 2023
Copy link
Collaborator

@adamTrz adamTrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@adamTrz
Copy link
Collaborator

adamTrz commented Mar 28, 2023

@szymonrybczak mind resolving conflicts? 🙏

@thymikee thymikee merged commit 54871b2 into react-native-community:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix docs Documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants