fix: replace launchPackager.sh with launchPackager.command
#1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
force-pushed
the
fix/add-missing-launchPackager
branch
from
0fa8b0e to
8a61207
Compare
szymonrybczak
force-pushed
the
fix/add-missing-launchPackager
branch
from
8a61207 to
67b8585
Compare
szymonrybczak
changed the title
launchPackager.commandlaunchPackager.sh with launchPackager.command
I'm out and about, but had a quick look. Not sure I understand the issue. Is this because someone set up associations to open .sh files in an editor instead of running them? |
|
Yeah, you're right. Fixed ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR replaces
launchPackager.shwithlaunchPackager.command, we though that we can uselaunchPackager.sh, but actually it doesn't work. Because in same cases when we ranopen -a Terminal.app /path/to/launchPackager.shit doesn't opens the Terminal.app with the script but the Code Editor with this file.Test Plan:
Metro bundler should be opened in right place in new terminal window.