Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --target option #1928

Merged

Conversation

szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented May 4, 2023

Summary:

Closes #1922

With this option we can specify what target will be used to run/build iOS app.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Inside iOS project duplicate the Xcode target and its build scheme.
  3. Run these commands:
    If target doesn't exist should select first available one:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios --target "someRandomTargetName" 

Should select target "second" for scheme "first":

node /path/to/react-native-cli/packages/cli/build/bin.js run-ios --scheme "first" --target "second" 

@github-actions github-actions bot added docs Documentation change feature labels May 4, 2023
@szymonrybczak szymonrybczak force-pushed the feat/addTargetOption branch from 6ce8038 to 788888f Compare May 4, 2023 08:24
Copy link
Collaborator

@adamTrz adamTrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :)

@szymonrybczak szymonrybczak force-pushed the feat/addTargetOption branch from b86432b to a10fd39 Compare May 15, 2023 16:40
@adamTrz adamTrz merged commit 0afde11 into react-native-community:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation change feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getTargetPaths of run-ios ignores build scheme when mode and scheme are specified
3 participants