Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve codebase #1945

Merged
merged 2 commits into from
May 30, 2023
Merged

chore: improve codebase #1945

merged 2 commits into from
May 30, 2023

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

  • Replaces ora direct usage with getLoader.
  • Fixes eslint warning with duplicate variable name.

Test Plan:

  • No eslint warnings.
  • CI Green. ✅

@github-actions github-actions bot added the infra Internal work not facing public APIs label May 30, 2023
@szymonrybczak szymonrybczak force-pushed the chore/improve-codebase branch from 1ee84ce to 582282d Compare May 30, 2023 07:43
@szymonrybczak szymonrybczak merged commit 237b966 into react-native-community:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamTrz adamTrz adamTrz approved these changes

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
infra Internal work not facing public APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szymonrybczak @thymikee @adamTrz