Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove generateStaticViewConfigs option from bundle command #1970

Merged

Conversation

huntie
Copy link
Collaborator

@huntie huntie commented Jun 16, 2023

Summary

Cleans up unused arg added in #1595. This property is not present in Metro's source code.

@dmytrorykun has confirmed that this flag is unused.

Changelog: None

Test Plan

@huntie huntie requested review from adamTrz and thymikee as code owners June 16, 2023 14:46
@huntie huntie changed the title Remove generateStaticViewConfigs option from bundle command chore: Remove generateStaticViewConfigs option from bundle command Jun 16, 2023
@huntie huntie force-pushed the drop-unused-bundle-option branch from 311194d to 99c62ee Compare June 16, 2023 14:54
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thymikee thymikee merged commit 0e4de11 into react-native-community:main Jun 16, 2023
@huntie huntie deleted the drop-unused-bundle-option branch June 16, 2023 15:47
EvanBacon added a commit to expo/expo that referenced this pull request Aug 24, 2023
# Why

- Pull in support for using the forked getAssets which supports
`EXPO_USE_METRO_WORKSPACE_ROOT` from
#24027

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

- Drop unused `--generate-static-view-configs`
react-native-community/cli#1970
- Update tests to use e2e fixture which has the expo package linked to
`packages`.
- Disable `watch` mode on metro when bundling for embed (we do this with
`npx expo export`).
- Use forked `getAssets` to support `EXPO_USE_METRO_WORKSPACE_ROOT`
correctly.
- Drop a bunch of unused option parsing.

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

- E2E bundling test.

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants