fix: "Multiple Podfiles were found" due to vendor inclusion #1988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
cli-plugin-ios
performs a glob search forPodfile
as a heuristic for the ios project root. In a default installation, where Bundler installs Cocoapods as a gem intovendor
, the vendored cocoapods directory itself contains a Podfile, and this leads to a harmless but noisy warning:This amends the existing exclusion list for the
Podfile
search (which already hardcodes and exclusion for eg/node_modules/
to also exclude Bundler's equivalent,/vendor/
.Test Plan:
Made this change locally (I happen to be working in RN 0.71.11 but I don't think anything relevant has changed here)
Before
After