Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use Homebrew for installing ios-deploy #2013

Merged
merged 2 commits into from
Jul 11, 2023
Merged

chore: use Homebrew for installing ios-deploy #2013

merged 2 commits into from
Jul 11, 2023

Conversation

szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented Jul 11, 2023 •
edited
Loading

Summary:

Fixes #2011
Changed the package manager for installing ios-deploy. We were installing package via npm or yarn, but to follow ios-deploy's offical docs we should install the package with Homebrew.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Make sure you have not installed ios-deploy package.
  3. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js doctor

Click f to try to fix issue, and ios-deploy package should be installed with Homebrew ✅

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak szymonrybczak changed the title chore: update ios-deploy installation error chore: use Homebrew to install ios-deploy Jul 11, 2023
@szymonrybczak szymonrybczak changed the title chore: use Homebrew to install ios-deploy chore: use Homebrew for installing ios-deploy Jul 11, 2023
@szymonrybczak szymonrybczak mentioned this pull request Jul 11, 2023
Closed
@thymikee thymikee merged commit 99ac933 into react-native-community:main Jul 11, 2023
thymikee pushed a commit that referenced this pull request Jul 11, 2023
@szymonrybczak @thymikee
chore: use Homebrew for installing ios-deploy (#2013)
9afb7cc 
* docs: update ios-deploy installation error

* chore: use Homebrew when installing `ios-deploy` with `doctor`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@adamTrz adamTrz Awaiting requested review from adamTrz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ios-deploy recommended installation method
2 participants
@szymonrybczak @thymikee