Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): ignore Pods and Hermes files when looking for AndroidManifest #2014

Conversation

szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented Jul 11, 2023

Summary:

Fixes #2012

It looks that the glob package was looking in wrong directories in my case (I tested this in RNTester on main). One thing that is interesting, before RN moved to monorepo the glob was finding AndroidManifest.xml immediately, but after RN moved fully to the monorepo, glob is looking into packages, which takes some time. But I think this change will make it enough fast.

Before this change:

0.71 0.72
CleanShot 2023-07-11 at 17 27 18@2x CleanShot 2023-07-11 at 17 28 51@2x

After this change:

0.71 0.72
CleanShot 2023-07-11 at 17 28 01@2x CleanShot 2023-07-11 at 17 30 34@2x

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-android

The first two logs:

info JS server already running.
info Installing the app...

should appear fast.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee
Copy link
Member

Mind adding a bit of context to the description? :)

@szymonrybczak
Copy link
Collaborator Author

Mind adding a bit of context to the description? :)

Done ✅

@thymikee thymikee changed the title fix: add paths to ignore in glob fix(perf): ignore Pods and Hermes files when looking for AndroidManifest Jul 11, 2023
@thymikee thymikee merged commit 151239f into react-native-community:main Jul 11, 2023
thymikee pushed a commit that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI has a big delay in starting Android apps in newer versions of React Native
2 participants