fix(perf): ignore Pods and Hermes files when looking for AndroidManifest #2014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #2012
It looks that the
glob
package was looking in wrong directories in my case (I tested this in RNTester onmain
). One thing that is interesting, before RN moved to monorepo theglob
was findingAndroidManifest.xml
immediately, but after RN moved fully to the monorepo, glob is looking into packages, which takes some time. But I think this change will make it enough fast.Before this change:
After this change:
Test Plan:
The first two logs:
should appear fast.
Checklist