-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade Metro to 0.78.0 #2047
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the default port is |
@szymonrybczak Yes, we can :). I haven't tackled this personally yet as there is the |
szymonrybczak
approved these changes
Aug 8, 2023
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 11, 2023
Summary: Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. WARNING: This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 ### To do - [ ] Bump CLI dependencies when next alpha published. - [ ] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: 964902e7b1bdd9a5ca16768d6b85ef6d9018b44c
2 tasks
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38944 Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. WARNING: This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 ### To do - [ ] Bump CLI dependencies when next alpha published. - [ ] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: 300f1b2553512150462cda328e87232ca1d93700
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 11, 2023
Summary: - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 - Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`. ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: 2586f084dd5e4f82b78709655727088842335d93
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 - Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`. ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: 757d915227040233d2d8375be4054d00926ca529
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 - Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`. ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: ae6c00944fe8bcfe6524dddfed8e18fc96e29945
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 - Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`. ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: 06247e60bc1ff77aa9bed48cb1e18293f5a7c419
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 - Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`. ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: 77c30bc92df3cc4d84a097e78519e097157293a4
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 - Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`. ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: f47f3e8b758691e3d3b46d4e05533d81b50f5616
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 - Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`. ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: 9957e29f5b0ca6d0d2d61aca6570757118246653
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 - Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`. ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: b290f2834691a680ba51ea19981f4e7b707b5a23
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: c09abbbbdc69faeccd6d1091a042e1502fb8dd97
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: c47d14af132089796724f0375f3795488a90f88d
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: bb90bf5776facc8b39050e1555e0b7009d046d99
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: 32aee8890db0c65791fe640c8993d06fc200f4ff
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: d08f0f8c3bd10f4de96b545b8ded7a4b22e6ae27
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: f83828efe2b6bb8da1bb2e11c523f71da601e46f
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: 101b7c9e529105a89d4ed68616432e3899c6c817
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 15, 2023
Summary: Pull Request resolved: facebook#38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: 393a6ebb06be94fb331908a47c8d409f64e63f77
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 15, 2023
Summary: Pull Request resolved: #38944 - Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes. - react-native-community/cli#2021 - react-native-community/cli#2024 - react-native-community/cli#2043 - react-native-community/cli#2047 ### To do WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~ - [x] Bump CLI dependencies when next alpha published. - [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48066179 fbshipit-source-id: b3dc8891cf33e537788f942dcaddff4d2f11a31f
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Metro to 0.78.0, removes the unreferenced dependencies on
metro-react-native-babel-transformer
andmetro-runtime
, and demotesmetro-resolver
to adevDependency
(as it is used only for types).Metro 0.78.0 contains the following breaking changes that we do not believe are breaking for CLI users:
metro-react-native-babel-transformer
andmetro-react-native-babel-preset
, which will be published as@react-native/metro-babel-transformer
and@react-native/babel-preset
going forward. (facebook/metro@799aa0a by @dmytrorykun)runInspectorProxy
option from server. (facebook/metro@2b0b15d by @huntie)DependencyGraph.resolveDependency
now takes a dependency object instead of a string. (facebook/metro@fbdd295 by @motiz88)inlineRequires
andnonInlinedRequires
to Babel transformers. (facebook/metro@e339c8f by @motiz88)See https://github.com/facebook/metro/releases/tag/v0.78.0 for the full changelog.
As a reminder, when updating the CLI version in React Native,
metro-runtime
and other Metro dependencies declared directly by React Native must be updated and pinned to the exact version used in the CLI (e.g. here"0.78.0"
).