Restore /launch-js-devtools endpoint (revert #2065) #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 21, 2023
Summary: Some tidying up around remote JS debugging while testing. See also react-native-community/cli#2083. Changelog: [Internal] Differential Revision: D49499068 fbshipit-source-id: 2e3c0a0e059333b95fca8ffbc2537ec5f01384c1
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 21, 2023
facebook#39582) Summary: Pull Request resolved: facebook#39582 Some tidying up around remote JS debugging while testing. See also react-native-community/cli#2083. ## Changelog: [iOS][Breaking] - Remove `openURL` method from `RCTInspectorDevServerHelper` Differential Revision: D49499068 fbshipit-source-id: 8ab000439133b7131c6b7310f87ff6229a57118d
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 21, 2023
facebook#39582) Summary: Pull Request resolved: facebook#39582 Some tidying up around remote JS debugging while testing. See also react-native-community/cli#2083. ## Changelog: [iOS][Breaking] - Remove `openURL` method from `RCTInspectorDevServerHelper` Reviewed By: cipolleschi Differential Revision: D49499068 fbshipit-source-id: b926bec49e2c67d2bc6662d32178cbb5baed2121
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 21, 2023
facebook#39582) Summary: Pull Request resolved: facebook#39582 Some tidying up around remote JS debugging while testing. See also react-native-community/cli#2083. ## Changelog: [iOS][Breaking] - Remove `openURL` method from `RCTInspectorDevServerHelper` Reviewed By: cipolleschi Differential Revision: D49499068 fbshipit-source-id: 662ca6353837a8423c67dd58003c376b0ae21ee6
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 21, 2023
facebook#39582) Summary: Pull Request resolved: facebook#39582 Some tidying up around remote JS debugging while testing. See also react-native-community/cli#2083. ## Changelog: [iOS][Breaking] - Remove `openURL` method from `RCTInspectorDevServerHelper` Reviewed By: cipolleschi Differential Revision: D49499068 fbshipit-source-id: cb700125c5c4818f51241f78f98e566fe355ee61
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 22, 2023
facebook#39582) Summary: Some tidying up around remote JS debugging while testing. See also react-native-community/cli#2083. ## Changelog: [iOS][Breaking] - Remove `openURL` method from `RCTInspectorDevServerHelper` Reviewed By: cipolleschi Differential Revision: D49499068
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 22, 2023
facebook#39582) Summary: Some tidying up around remote JS debugging while testing. See also react-native-community/cli#2083. ## Changelog: [iOS][Breaking] - Remove `openURL` method from `RCTInspectorDevServerHelper` Reviewed By: cipolleschi Differential Revision: D49499068
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 22, 2023
#39582) Summary: Pull Request resolved: #39582 Some tidying up around remote JS debugging while testing. See also react-native-community/cli#2083. ## Changelog: [iOS][Breaking] - Remove `openURL` method from `RCTInspectorDevServerHelper` Reviewed By: cipolleschi Differential Revision: D49499068 fbshipit-source-id: 843ef6cf1af658756466854fc1a0b3edd91c1f37
ShevO27
pushed a commit
to ShevO27/react-native
that referenced
this pull request
Sep 26, 2023
facebook#39582) Summary: Pull Request resolved: facebook#39582 Some tidying up around remote JS debugging while testing. See also react-native-community/cli#2083. ## Changelog: [iOS][Breaking] - Remove `openURL` method from `RCTInspectorDevServerHelper` Reviewed By: cipolleschi Differential Revision: D49499068 fbshipit-source-id: 843ef6cf1af658756466854fc1a0b3edd91c1f37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
NativeDevSettings.setIsDebuggingRemotely(true)✅ Auto-launches
/debugger-ui, connects external JS runtime