-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: log files in selected directory and add option to replace them #2100
Conversation
There's a problem with mocking |
bbe7b3b
to
3532c73
Compare
3532c73
to
65b09d8
Compare
CI green, @thymikee mind going through changes? |
for (const conflict of conflicts) { | ||
logger.log(` ${conflict}`); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be the part of the logger.warn
so that the connected messages are kept together. In case someone wanted to only inspect "warn"s they wouldn't see relevant data for this message
1d9a5b1
to
9bc868e
Compare
101ec96
to
50a5627
Compare
50a5627
to
3f6e7e1
Compare
3f6e7e1
to
09090cb
Compare
CI Green, good to merge! |
Summary:
In this PR I added option to replace existing files in the selected directory.
Related #1591
Test Plan:
hello
with few filesChecklist