perf: remove Gradle task check on run-android #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamTrz
approved these changes
Oct 31, 2023
thymikee
reviewed
Oct 31, 2023
packages/cli-platform-android/src/commands/runAndroid/listAndroidTasks.ts
Outdated
Show resolved
Hide resolved
Love this :) |
|
We should backport this to 0.72 cc. @thymikee |
thymikee
added a commit
that referenced
this pull request
Oct 31, 2023
thymikee
pushed a commit
that referenced
this pull request
Oct 31, 2023
* remove gradle task check on run-android * add loader and README note * throw error when no tasks found
2 tasks
|
@szymonrybczak here: #2145 |
thymikee
added a commit
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Related: #2012
When running
run-androidcommand, it takes a lot of time to build the app for more complex projects with lots of dependencies and different flavors. It is caused by the code checking if the task for provided mode exists. Under the hood, it's running./gradlew taskswhich takes a lot of time. A good example of such complex project is Expensify App, where delay in building the app takes ~4mins.Here is a screenshot from profiling report of
./gradlew tasks --group installfrom Expensify :This PR removes this check - Gradlew itself throws an error if the task for provided mode does not exist so we can rely on that:
Additionally, getting task list should still exist in the interactive mode. Unfortunately in more complex projects, it might stil take a lot of time to execute. A note about it was added to the docs. As a DX improvement, I added the loader indicating that the process is currently looking for Gradle tasks.
Test Plan:
node path/to/cli run-androidnode path/to/cli run-android --mode Aaanode path/to/cli run-android --interactiveChecklist