Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): show simulator version in prompt #2214

Merged
merged 1 commit into from
Dec 18, 2023
Merged

feat(ios): show simulator version in prompt #2214

merged 1 commit into from
Dec 18, 2023

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

Sometimes when user has installed few iOS version, it might be helpful to show simulator version to allow them to pick right one to run.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios --list-devices
  1. Should list simulators with iOS versions

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee thymikee merged commit 1e6ea84 into main Dec 18, 2023
9 of 10 checks passed
@thymikee thymikee deleted the feat/show-version-when-listing-devices branch December 18, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szymonrybczak @cipolleschi @thymikee