feat: add strict typing for supported platforms #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwasniewski
force-pushed
the
feat/cli-platform-apple-types
branch
from
7ab0750 to
0031400
Compare
thymikee
approved these changes
Dec 20, 2023
okwasniewski
force-pushed
the
feat/cli-platform-apple-types
branch
2 times, most recently
from
9be3476 to
da7a67e
Compare
okwasniewski
force-pushed
the
feat/cli-platform-apple-types
branch
from
da7a67e to
e4ad8be
Compare
|
I think this is also ready to merge cc: @thymikee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds strict typing for supported platforms inside of
cli-platform-apple.Part of #2217
Test Plan:
CI Green
Checklist