refactor: extract duplicated code to getXcodeProjectAndDir
#2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
thymikee
reviewed
Dec 20, 2023
packages/cli-platform-apple/src/commands/buildCommand/createBuild.ts
Outdated
Show resolved
Hide resolved
okwasniewski
force-pushed
the
feat/cli-platform-apple-pods
branch
from
ba5a561
to
b4126f0
Compare
thymikee
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR extracts duplicated code to re-check Xcode project between run and build commands, part of #2217
Test Plan:
CI Green
Checklist