Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn about multiple podfiles only if provided platform is unsupported #2223

Merged

Conversation

okwasniewski
Copy link
Contributor

Summary:

This PR warns about multiple podfiles only if user is using an unsupported platform directory (for example: native-ios-folder for ios root).

It also provides a useful error message when user overrides the sourceDir for given platform. For example:

For this react-native.config.js:

module.exports = {
  project: {
    visionos: {
      sourceDir: './not-exist',
    },
  },
};

We show this error:

CleanShot 2023-12-20 at 16 39 41@2x

Test Plan:

Init multi-platform project and check if the warning is there

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@okwasniewski okwasniewski force-pushed the feat/multiple-podfiles branch from 6932ec8 to 064de9d Compare December 21, 2023 12:31
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
@thymikee thymikee merged commit 043c831 into react-native-community:main Dec 21, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants