feat: convert command options and dependencyConfig into getters #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
thymikee
approved these changes
Dec 21, 2023
okwasniewski
force-pushed
the
feat/commandOptionsGetters
branch
from
6426ad7 to
dd15e98
Compare
|
I think we can do a release after this one, as it's the last PR with API change. cc: @thymikee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR converts buildOptions and runOptions to follow the same builder pattern. That way we can remove irrelevant platform options and stick to a consistent pattern.
Dependency config is now also a builder for consistent usage. Example of
run-visionos --help:Test Plan:
Test --help command
Checklist