feat: allow overriding commands from react-native.config.js

[szymonrybczak]

Summary:

Closes #2227, from now commands added inside react-native.config.js will override existing ones.

Test Plan:

1. Clone the repository and do all the required steps from the Contributing guide
2. Createreact-native.config.js file with following content:

module.exports = {
  commands: [
    {
      name: 'start',
      func: () => {
        console.log('hello!');
      },
    },
  ],
};

3. Run this command:

node /path/to/react-native-cli/packages/cli/build/bin.js start

4. Command should be replaced ✅

Checklist

• Documentation is up to date to reflect these changes.
• Follows commit message convention described in CONTRIBUTING.md

[tom-sherman]

Any idea how we can make this work for start? In my testing the one added by react-native takes precedence over the one in my config.

[szymonrybczak]

In my testing the one added by react-native takes precedence over the one in my config.

I don't quite understand what do you mean here 🤔

I created new project, added Re.Pack with npx @callstack/repack-init and command is correctly overwritten.

CleanShot.2023-12-22.at.16.38.03.mp4

[szymonrybczak]

@tom-sherman bump :) ⬆️

[tom-sherman]

Hmm, could it be the react native version I'm running? I tried applying this as a patch to my RN 0.72.5 app and it continued to use metro.

It's probably just my setup in any case, so pls don't block the PR on my experience!

[szymonrybczak]

Hmm, could it be the react native version I'm running?

I don't think so. Did you follow CONTRIBUTING.md?

[tom-sherman]

I applied the change manually with pnpm patch, so again could be something I did wrong there also 😅

[thymikee]

Let's add a test for this behavior in index-test.ts. The writeFiles should include 2 dependency commands and one root config that overrides one of the commands explicitly.

[szymonrybczak]

Let's add a test for this behavior in index-test.ts. The writeFiles should include 2 dependency commands and one root config that overrides one of the commands explicitly.

Done ✅

[thymikee]

Let's document this