Update getLatestRelease.ts
to use currentVersion
in diffUrl
#2231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As per 5774e6a#r135571193 I think a copy-paste error happened while refactoring this code. This is the current output printed by the
printNewRelease
function:Note how the
from
query param of the diff URL uses the stable version instead of the current.This is the code prior to the commit that introduced the issue:
cli/packages/cli-tools/src/releaseChecker/getLatestRelease.ts
Line 62 in 78a1742
Test Plan:
This is a simple change, which I applied locally to test it.
Checklist