Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getLatestRelease.ts to use currentVersion in diffUrl #2231

Conversation

kraenhansen
Copy link
Contributor

Summary:

As per 5774e6a#r135571193 I think a copy-paste error happened while refactoring this code. This is the current output printed by the printNewRelease function:

info React Native v0.73.1 is now available (your project is running on v0.73.0).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.73.1
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.73.1
info For more info, check out "https://reactnative.dev/docs/upgrading?os=macos".

Note how the from query param of the diff URL uses the stable version instead of the current.

This is the code prior to the commit that introduced the issue:

diffUrl: buildDiffUrl(currentVersion),

Test Plan:

This is a simple change, which I applied locally to test it.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

kraenhansen referenced this pull request Dec 22, 2023
The upgrade helper has a high failure rate. Linking the user to the
upgrade helper is the best way to deprecate this feature.
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@thymikee thymikee merged commit e3fb3c8 into react-native-community:main Dec 22, 2023
9 of 10 checks passed
@kraenhansen kraenhansen deleted the kh/use-current-version-in-diff-url branch December 22, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants