Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt buildRun to properly open macOS apps #2232

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented Dec 22, 2023

Summary:

Related: #2217

Adapts buildRun function to properly open macOS apps. If the platform is macos, we're executing this command to start app:

❯ open "/path/to/app"

This PR will allows us to seamlessly remove local-cli from react-native-macos and replace it with the this implementation.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios

Should work the same

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee
Copy link
Member

thymikee commented Jan 3, 2024

@szymonrybczak can you please rebase now that installing in opening are split?

@szymonrybczak szymonrybczak force-pushed the feat/adapt-builder-to-launch-macos-app branch from 22a770b to 800b5bc Compare January 7, 2024 12:56
@szymonrybczak
Copy link
Collaborator Author

E2E tests are failing due to the problem with boost pod, more context: facebook/react-native#42109. As for now there's a workaround with adding patch, but we cannot do it here, since we're creating new project.

@thymikee thymikee merged commit d864bc0 into main Jan 8, 2024
6 of 10 checks passed
@thymikee thymikee deleted the feat/adapt-builder-to-launch-macos-app branch January 8, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants