Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate unstable_reactLegacyComponentNames #2264

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

cortinico
Copy link
Member

Summary:

Related to:

With RN 0.74 specifying the legacy components name wont' be necessary anymore as the framework will detect it automatically.

Test Plan:

Not sure how to test this. I'm basically ignoring the unstable_reactLegacyComponentNames. We can remove this in 0.75

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@cortinico cortinico requested review from cipolleschi and removed request for thymikee and adamTrz January 16, 2024 10:56
@github-actions github-actions bot added docs Documentation change feature labels Jan 16, 2024
docs/projects.md Outdated
@@ -91,7 +89,7 @@ Array of strings that will be passed to the `npx react-native run-ios` command w

#### project.ios.unstable_reactLegacyComponentNames

> Note: Only applicable when new architecture is turned on.
> Note: Deprecated in React Native 0.74. Only applicable when new architecture is turned on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a PR that adds this to iOS as well? Currently facebook/react-native#42294 refers to Android only

@thymikee
Copy link
Member

Added a warning that surfaces whenever config is read (e.g. for run-android, config)

Screenshot 2024-01-16 at 13 44 13

If you confirm this is also what happens for iOS, I'll add it there as well

@thymikee
Copy link
Member

Found this for iOS: facebook/react-native#41656

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cortinico cortinico merged commit 0105408 into main Jan 16, 2024
10 checks passed
@cortinico cortinico deleted the nc/automatic-interop branch January 16, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation change feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants