fix: replace ip package with default value and --host flag
#2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
force-pushed
the
fix/replace-ip-package-with-localhost
branch
from
d6cc085
to
f05c777
Compare
TMisiukiewicz
approved these changes
Feb 16, 2024
| @@ -19,7 +19,6 @@ | |||
| "envinfo": "^7.10.0", | |||
| "execa": "^5.0.0", | |||
| "hermes-profile-transformer": "^0.0.6", | |||
| "ip": "^1.1.5", | |||
There was a problem hiding this comment.
since it was in package.json, was it used anywhere in the doctor command?
There was a problem hiding this comment.
no, i guess it was a leftover after some package refactors.
nhasoenhasan
approved these changes
Feb 19, 2024
thymikee
approved these changes
Feb 19, 2024
szymonrybczak
added a commit
that referenced
this pull request
Feb 19, 2024
# Conflicts: # yarn.lock
szymonrybczak
added a commit
that referenced
this pull request
Feb 19, 2024
# Conflicts: # packages/cli-hermes/README.md # yarn.lock
thymikee
pushed a commit
that referenced
this pull request
Feb 19, 2024
# Conflicts: # packages/cli-hermes/README.md # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #2294
In this Pull Request I've replace usage of
ippackage with default valuelocalhost, and added option to specify custom if needed. (It's following the same logic that is insidestartcommand).Test Plan:
Checklist