-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correctly display errors in react-native init #2394
Merged
thymikee
merged 5 commits into
react-native-community:main
from
islandryu:fix/errorHandle
Sep 9, 2024
Merged
fix: Correctly display errors in react-native init #2394
thymikee
merged 5 commits into
react-native-community:main
from
islandryu:fix/errorHandle
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Jun 24, 2024
thymikee
reviewed
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for contributing this! Can you please rebase to resolve conflicts?
szymonrybczak
force-pushed
the
fix/errorHandle
branch
3 times, most recently
from
July 4, 2024 13:26
d3ce962
to
fb440f8
Compare
szymonrybczak
force-pushed
the
fix/errorHandle
branch
from
July 4, 2024 13:28
fb440f8
to
75fd26c
Compare
thymikee
reviewed
Jul 5, 2024
thymikee
reviewed
Jul 5, 2024
thymikee
approved these changes
Sep 9, 2024
thymikee
pushed a commit
that referenced
this pull request
Sep 12, 2024
* fix: Display correct error when config file does not exist * fix: move cocoaPods Error * fix: prettify output * fix: pass an error * fix: do cleanup before exiting process --------- Co-authored-by: szymonrybczak <szymon.rybczak@gmail.com>
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The problem I noticed was that when I specified the wrong template, the error wording was funny.
However, looking at the source code, this issue as well as many other errors are not displayed correctly.
The error handling part of cocoapods seems to be wrong.
Moved pods error handling out of the way of the others, and added additional unknown error handling.
Test Plan:
Run
react-native init TestProduct --template typescript
and check correct error message.Confirmation of pod error on pod failure.
Checklist